[lvm-devel] [PATCH 4/4] Update tests for lvseg apis.
Zdenek Kabelac
zkabelac at redhat.com
Wed Oct 20 12:08:46 UTC 2010
Dne 19.10.2010 15:24, Dave Wysochanski napsal(a):
>
> Signed-off-by: Dave Wysochanski <dwysocha at redhat.com>
> ---
> test/api/test.c | 76 ++++++++++++++++++++++++++++--------------------------
> 1 files changed, 39 insertions(+), 37 deletions(-)
>
> diff --git a/test/api/test.c b/test/api/test.c
> index fea3d0d..20f4210 100644
> --- a/test/api/test.c
> +++ b/test/api/test.c
> @@ -69,6 +69,8 @@ static void _show_help(void)
> "List the PVs that exist in VG vgname\n");
> printf("'vg_list_lvs vgname': "
> "List the LVs that exist in VG vgname\n");
> + printf("'lv_list_lvsegs vgname lvname': "
> + "List the LV segments that exist in LV vgname/lvname\n");
> printf("'vgs_open': "
> "List the VGs that are currently open\n");
> printf("'vgs': "
> @@ -569,12 +571,15 @@ static void _vg_tag(char **argv, int argc, int add)
> add ? "adding":"removing", argv[2], argv[1]);
> }
>
> -static void _print_property_value(struct lvm_property_value value)
> +static void _print_property_value(const char *name,
> + struct lvm_property_value v)
const struct if you do not modify it.
And I think using pointer would be wise decision here.
>
> static void _pv_get_property(char **argv, int argc)
> @@ -589,17 +594,7 @@ static void _pv_get_property(char **argv, int argc)
const array of const pointers ?
Zdenek
More information about the lvm-devel
mailing list