[lvm-devel] [PATCH 11/14] Add lvm_vg_get_property() generic vg property function.
Dave Wysochanski
dwysocha at redhat.com
Fri Oct 15 14:18:49 UTC 2010
On Tue, 2010-10-12 at 13:05 +0200, Petr Rockai wrote:
> Zdenek Kabelac <zkabelac at redhat.com> writes:
> >> + struct lvm_property_type prop;
> >> +
> >> + strncpy(prop.id, name, LVM_PROPERTY_NAME_LEN);
> >
> > Hmmm why doing a copy here instead of passing/assigning 'name' ptr somewhere?
>
> Because lvm_property_type says: char id[LVM_PROPERTY_NAME_LEN];
>
> Yours,
> Petr.
>
Thanks both of you for the feedback. I am reworking this based on all
your comments and will re-post soon.
More information about the lvm-devel
mailing list