[lvm-devel] LVM2 ./WHATS_NEW lib/metadata/metadata.c tools ...
Alasdair G Kergon
agk at redhat.com
Tue Jan 4 23:59:08 UTC 2011
On Wed, Dec 22, 2010 at 03:36:43PM -0000, zkabelac at sourceware.org wrote:
> Add backtraces for backup and backup_remove fail paths
> + if (!backup_remove(vg->cmd, vg->name))
> + stack;
We also have:
int backup_remove(struct cmd_context *cmd, const char *vg_name)
{
...
/*
* Let this fail silently.
*/
unlink(path);
return 1;
}
I suggest you change that into a log_sys_debug() now rather than a void cast.
(No harm logging ENOENT and could be useful to know that sometimes.)
Alasdair
More information about the lvm-devel
mailing list