[Ovirt-devel] Re: [PATCH node] Added support for local storage configuration.

Jim Meyering jim at meyering.net
Wed Nov 19 17:28:42 UTC 2008


Alan Pevec <apevec at redhat.com> wrote:
...
> This part was modified in the follow up patch, so Jim please amend: OVIRT_(.*)_SIZE -> OVIRT_VOL_\1
>
> +BOOT_SIZE=${OVIRT_BOOT_SIZE=$default_boot_size}
> +ROOT_SIZE=${OVIRT_ROOT_SIZE=$default_root_size}
> +LOGGING_SIZE=${OVIRT_LOGGING_SIZE=$default_logging_size}
> +CONFIG_SIZE=${OVIRT_CONFIG_SIZE=$default_config_size}
> +
> if [ "$1" == "AUTO" ]; then
> +    # In "AUTO" mode, OVIRT_VOL should be defined in the environment.
>     DRIVE=$OVIRT_VOL
> -    if [ -n "$OVIRT_BOOT_SIZE" ]; then BOOT_SIZE=$OVIRT_BOOT_SIZE; else BOOT_SIZE=256; fi
> -    if [ -n "$OVIRT_ROOT_SIZE" ]; then ROOT_SIZE=$OVIRT_ROOT_SIZE; else ROOT_SIZE=256; fi
> -    if [ -n "$OVIRT_LOGGING_SIZE" ]; then LOGGING_SIZE=$OVIRT_LOGGING_SIZE; else LOGGING_SIZE=512; fi
> -    if [ -n "$OVIRT_CONFIG_SIZE" ]; then CONFIG_SIZE=$OVIRT_CONFIG_SIZE; else CONFIG_SIZE=5; fi

Thanks, Alan.

I'll amend with this:

diff --git a/scripts/ovirt-config-storage b/scripts/ovirt-config-storage
index 81dadef..efbd56e 100755
--- a/scripts/ovirt-config-storage
+++ b/scripts/ovirt-config-storage
@@ -231,10 +231,10 @@ esac
 MEM_SIZE=$(echo "scale=0; $MEM_SIZE / 1024" | bc -l)
 SWAP_SIZE=$MEM_SIZE

-BOOT_SIZE=${OVIRT_BOOT_SIZE=$default_boot_size}
-ROOT_SIZE=${OVIRT_ROOT_SIZE=$default_root_size}
-LOGGING_SIZE=${OVIRT_LOGGING_SIZE=$default_logging_size}
-CONFIG_SIZE=${OVIRT_CONFIG_SIZE=$default_config_size}
+BOOT_SIZE=${OVIRT_VOL_BOOT=$default_boot_size}
+ROOT_SIZE=${OVIRT_VOL_ROOT=$default_root_size}
+LOGGING_SIZE=${OVIRT_VOL_LOGGING=$default_logging_size}
+CONFIG_SIZE=${OVIRT_VOL_CONFIG=$default_config_size}

 if [ "$1" == "AUTO" ]; then
     # In "AUTO" mode, OVIRT_VOL should be defined in the environment.




More information about the ovirt-devel mailing list