[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
Re: [PATCH 2.5.69.bk9] Fix reference counts for pages (take 1) [was RE: condvar wakeups]
- From: Saurabh Desai <sdesai austin ibm com>
- To: "Perez-Gonzalez, Inaky" <inaky perez-gonzalez intel com>
- Cc: "'Ingo Molnar'" <mingo elte hu>, "'Ulrich Drepper'" <drepper redhat com>, "'NPTL mailing list'" <phil-list redhat com>
- Subject: Re: [PATCH 2.5.69.bk9] Fix reference counts for pages (take 1) [was RE: condvar wakeups]
- Date: Thu, 15 May 2003 16:34:35 -0500
"Perez-Gonzalez, Inaky" wrote:
> This is the first take at it; I still didn't have time to test it
> (0.37 building, slow) ... but I don't think I screwed up anything
> - Saurabh, would you mind torturing it a little bit in your x4 to
> make sure it is not leaking memory anywhere? Performance wise it
> should do nothing to the system ...
>
This patch cause about 30% slowdown with or without requeue NPTL.
And I found out why, you didn't return from __pin_page() as before
(for the fastpath). It should be like (in __pin_page()),
+ if (likely(page != NULL))
+ return __pin_page_atomic(page);
With this, it works as before. I think its costing little bit for
unpin/pin in the requeue case, which is required anyway.
- Saurabh
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]