Building subversion javahl bindings

[Pedro LamarÃo <pedro lamarao mndfck org>]

I've got this patch to subversion.spec that allows optional building of 
javahl bindings with a variable-specified JDK path.
I've built it as I need Subclipse to work.
What do you all think?

--
Pedro LamarÃo

--- subversion.spec.orig	2005-01-14 11:11:53.000000000 -0200
+++ subversion.spec	2005-01-14 11:17:18.000000000 -0200
@@ -1,6 +1,10 @@
 # set to zero to avoid running test suite
 %define make_check 1
 
+# set JDK path to build javahl; default for JPackage
+%define make_javahl 0
+%define jdk_path /usr/lib/jvm/java
+
 %define perl_vendorarch %(eval "`%{__perl} -V:installvendorarch`"; echo $installvendorarch)
 
 ExclusiveArch: i386 x86_64 ppc
@@ -71,6 +75,15 @@
 %description perl
 This package includes the Perl bindings to the Subversion libraries.
 
+%package javahl
+Group: Development/Libraries
+Summary: JNI bindings to the Subversion libraries
+#BuildRequires: jdk
+Requires: subversion = %{version}-%{release}
+
+%description javahl
+This package includes the JNI bindings to the Subversion libraries.
+
 %prep
 %setup -q
 %patch1 -p1 -b .swig
@@ -96,11 +109,17 @@
         --with-apxs=%{_sbindir}/apxs --disable-mod-activation
 make %{?_smp_mflags} all swig-py %{swigdirs} 
 make swig-pl
+%if %{make_javahl}
+make javahl
+%endif
 
 %install
 rm -rf ${RPM_BUILD_ROOT}
 make install install-swig-py install-swig-pl-lib \
         DESTDIR=$RPM_BUILD_ROOT %{swigdirs}
+%if %{make_javahl}
+make install-javahl DESTDIR=$RPM_BUILD_ROOT
+%endif
 
 make pure_vendor_install -C subversion/bindings/swig/perl/native \
         PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
@@ -193,6 +212,11 @@
 %{_libdir}/libsvn_swig_perl*
 %{_mandir}/man*/*::*
 
+%files javahl
+%defattr(-,root,root,-)
+%{_libdir}/libsvnjavahl-1.*
+%{_libdir}/svn-javahl
+
 %changelog
 * Mon Jan 10 2005 Joe Orton <jorton redhat com> 1.1.2-2.3
 - use upstream libsvn_swig_perl build fix (r12144, r12485)