Re: question re: best practices,

[Jeff Johnson <jbj redhat com>]

On Fri, May 10, 2002 at 05:52:20PM -0600, Rob Nagler wrote:
> As long as we're on the subject of maintainability, why is:
> 
> %files
> %defattr(-,root,root)
> %doc CREDITS Changes README SUPPORT ToDo cgi_to_mod_perl.pod mod_perl.pod
> %doc mod_perl_method_handlers.pod mod_perl_traps.pod mod_perl_tuning.pod
> %doc INSTALL faq/*.html eg faq
> %doc ToDo apache-modlist.html
> %{contentdir}/html/manual/mod/*
> %{_libdir}/apache/libperl.so
> %{_libdir}/perl?/site_perl/*/*/auto/*
> %{_libdir}/perl?/site_perl/*/*/Apache*
> %{_libdir}/perl?/site_perl/*/*/Bundle/*
> %{_libdir}/perl?/site_perl/*/*/cgi*
> %{_libdir}/perl?/site_perl/*/*/mod_perl*
> %{_mandir}/man3/*.3*
> 
> better than:
> 
> (
>     echo '%defattr(-,root,root)'
>     find . -name CVS -prune -o -type l -print -o -type f -print \
>         | sed -e 's/^\.//' \
>         | grep -v '/files.list$'
> ) > %{build_root}/files.list
> 
> %files -f %{build_root}/files.list
> 
> Every RPM doc says that we shouldn't use find to get the files to
> install.  They also don't recommend relying on build root.  We have
> been doing this for two years without a problem.  Comments?

Point me at any RPM doco that sez' not to use find to generate %files, and I
will eradicate immediately.

Generating the %files manifest correctly is *THE* most painful part
pf packaging, and there's no reason not to use find if it does a
better job.

Same considerations apply to m4 and cvs, for that matter: if the
tool does a better job, use it.

73 de Jeff

-- 
Jeff Johnson	ARS N3NPQ
jbj@redhat.com (jbj@jbj.org)
Chapel Hill, NC