Re: [Spacewalk-list] Modification of spacewalk-service script

[Jan Pazdziora <jpazdziora redhat com>]

On Thu, Nov 10, 2011 at 08:36:18AM +0100, Pierre Casenove wrote:
> Hello,
> Please find attached a proposed patch for this.
> I've added database.control boolean directly in rhn.conf file.
> I've modified the spacewalk-service script to manage this parameter. In all
> cases, oracle is controlled, for compatibility with RH Satellite product.
> I've left commented out a sleep before starting osa-dispatcher: this sleep
> allows to get rid of osa-dispatcher error connecting to jabberd. I couldn't
> find another find to check if jabberd was ready to accept connection. Feel
> free to either remove it or uncomment it.

I'm against this change. The database (PostgreSQL, Oracle XE) is
completely independent from the Spacewalk software product and the
spacewalk-service script should have no business fiddling with them.

If for some reason (what reason, exactly?) you need to restart
everything with one script, why not write a wrapper around it?

-- 
Jan Pazdziora
Principal Software Engineer, Satellite Engineering, Red Hat