Re: [virt-tools-list] Virt-viewer plugin for Mozilla and scaling

["Daniel P. Berrange" <berrange redhat com>]

On Tue, Jul 28, 2009 at 12:03:09AM +0200, Guido G?nther wrote:
> On Sun, Jul 26, 2009 at 08:47:47PM -0400, Cole Robinson wrote:
> > Laurent Léonard wrote:
> > > Le vendredi 17 juillet 2009 à 20:49, Daniel P. Berrange a écrit :
> > >> On Fri, Jul 17, 2009 at 04:49:15PM +0200, Laurent L?onard wrote:
> > >>> The first time I used the Virt-viewer plugin for Mozilla the guest's
> > >>> screen was scaled to the size specified in the embed object. I don't know
> > >>> why this behavior changed. Do you have an idea about that ?
> > >> Previously we only enabled scaling if you did *not* have Compiz
> > >> running as your window manager due to OpenGL conflict problems.
> > >> IIRC since we replaced our opengl code with cairo we now have
> > >> scaling enabled for everyone by default.
> > >>
> > >> Daniel
> > > 
> > > Could you point me a patch for the OpenGL code replacement with Cairo to 
> > > enable scaling with composite window managers ?
> > > 
> > 
> > AIUI, it should be in latest released version of gtk-vnc.
> It is, but current virt-viewer relases still have:
> 
>       if (!gtk_widget_is_composited(window))
>                 vnc_display_set_scaling(VNC_DISPLAY(vnc), TRUE);
> 
> so scaling isn't enabled when the widget is composited (the property
> defaults to false in gtk-vnc).

I'm going to fix that to default to on, and also make it preserve the
aspect ratio when scaling.


Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|