[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH] systray: toogle Manager on click and a pref. to keep running in tray



On 10/21/2009 02:39 PM, Jon Nordby wrote:
> Patch reworked based upon proposed changes. Much simpler now. No
> notification however.
> 

One issue with this that I just thought of: you could have no top level
windows running, and the systray icon could disappear (possibly by
somebody changing the gconf entry from the cli, or a left open
preferences window). This would leave the virt-manager process running
with no GUI way to stop it.

We should register a listener on the systray gconf preference in
engine.py that will stop the app if windows == 0.

> diff -r e363de9ac549 -r 351eb3b240ce src/virtManager/engine.py
> --- a/src/virtManager/engine.py	Wed Oct 21 12:01:53 2009 -0400
> +++ b/src/virtManager/engine.py	Wed Oct 21 20:13:51 2009 +0200
> @@ -78,7 +78,7 @@
>              logging.debug("Libvirt doesn't support threading, skipping.")
>  
>          # Counter keeping track of how many manager and details windows
> -        # are open. When it is decremented to 0, close the app
> +        # are open. When it is decremented to 0, close the app or keep running in tray
>          self.windows = 0
>  

Still a long line.

Other than that, it's fine.

Thanks,
Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]