[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Fixup DiskSet._askForLabelPermission()



> This function seems to have gotten horribly screwed
> up lately:
> 
>  - We never actually query the user about initialising
>    the partition table; so if you've got an unitialized
>    partition table, there's no way to install
> 
>  - We've create two versions of the message string and
>    use neither
> 
>  - We test for "ks and (drive in clearDevs) and initAll"
>    twice; the second test can never be true, obviously
> 
>  - We test for "not intf" twice, again the second can't
>    be true
> 
> Patch is untested, but it's clearly an improvement :-)

I'm fine with taking this, but I'd prefer to wait until after the beta
is done unless you think it's a beta blocking issue.

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]