[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Don't mount bind mounts last, that makes /dev break.



On Thu, 2009-04-30 at 14:53 -0400, Peter Jones wrote:
> Remove the chunk of code that sortds bind mounts to the end.  It appears
> to be completely bogus, and certainly breaks mounting of /dev during
> installation.

I did a quick test here and it seems fine.

> ---
>  storage/__init__.py |    5 -----
>  1 files changed, 0 insertions(+), 5 deletions(-)
> 
> diff --git a/storage/__init__.py b/storage/__init__.py
> index d7b53b6..463d6c1 100644
> --- a/storage/__init__.py
> +++ b/storage/__init__.py
> @@ -1542,11 +1542,6 @@ class FSSet(object):
>          devices = self.mountpoints.values() + self.swapDevices
>          devices.extend([self.dev, self.devshm, self.devpts, self.sysfs, self.proc])
>          devices.sort(key=lambda d: getattr(d.format, "mountpoint", None))
> -        for device in devices[:]:
> -            # make sure all the bind mounts are at the end of the list
> -            if device.format.type == "bind":
> -                devices.remove(device)
> -                devices.append(device)
>  
>          for device in devices:
>              if not device.format.mountable or not device.format.mountpoint:


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]