[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Second part of the s390x xauth fix - copy the files to initrd (#516369)



> I'm wondering why we use cp for s390(x) but the remainder of the
> function makeinitrd uses install or instbin.
> 
> Maybe that's the reason the so-deps didn't get resolved?
> 
> Shouldn't that be all we need?:
> 
> -        cp $IMGPATH/usr/bin/xauth $MBD_DIR/sbin/xauth
> +        instbin $IMGPATH /usr/bin/xauth $MBD_DIR /sbin/xauth

Yes, we should definitely be using instbin here.  That'll get rid of the
need for copying all the libraries by hand because we'll run
get_dso_deps on the binary that way.  Good catch.

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]