[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 4/4] If anaconda is not run from loader or liveinst, fail.



Chris Lumens (clumens redhat com) said: 
> diff --git a/anaconda b/anaconda
> index ed72947..4aa002a 100755
> --- a/anaconda
> +++ b/anaconda
> @@ -642,9 +642,19 @@ if __name__ == "__main__":
>  
>      (opts, args) = parseOptions()
>  
> +    try:
> +        parent = os.path.realpath("/proc/%s/exe" % os.getppid())
> +    except:
> +        parent = "/sbin/loader"
> +
>      if opts.unsupportedMode:
>          stdoutLog.error("Running anaconda in %s mode is no longer supported." % opts.unsupportedMode)
>          sys.exit(0)
> +    elif not opts.liveinst or not parent.endswith("/loader"):
> +        stdoutLog.error("Running anaconda from the command line is not supported.\n"
> +                        "Please start anaconda either from the boot media or from "
> +                        "the livecd environment.")
> +        sys.exit(0)
>  
>      # Now that we've got arguments, do some extra processing.
>      instClass = getInstClass()

As mentioned on IRC, I would think that the entirety of checks on
'opts.livenst' could be replaced with checks for the liveinst install
method; as it stands, you could pass --liveinst --method http://...., which
would likely explode spectacularly. But that would happen before this patch,
too.

Bill


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]