[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 2/2] Don't set doAutoPart on interactive kicsktart installs (#496896).



On Mon, 2009-05-04 at 17:18 -0400, Chris Lumens wrote:

So they have partitioning commands in their config, then they come to
the autopart screen. It says "replace existing system". They click
"next". They end up with the partitioning they specified in their
config, not autopart. Is this the sequence? If so, we're doing it wrong.

If they've given partitioning commands, the autopart screen should be
preloaded so that if they just click next they will have chosen "custom
layout". Just like if they went backwards in a non-kickstart install.

Have I got it wrong?

> ---
>  iw/autopart_type.py |   10 ++++++++--
>  1 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/iw/autopart_type.py b/iw/autopart_type.py
> index 1b35573..164f069 100644
> --- a/iw/autopart_type.py
> +++ b/iw/autopart_type.py
> @@ -175,10 +175,16 @@ class PartitionTypeWindow(InstallWindow):
>                  self.storage.encryptionPassphrase = ""
>                  self.storage.retrofitPassphrase = False
>                  self.storage.encryptedAutoPart = False
> -            
> -            self.storage.doAutoPart = True
> +
>              self.storage.clearPartType = val
>  
> +            # If this is an interactive kickstart install, do not set
> +            # doAutoPart as that'll set us up to try to make the default
> +            # partitioning layout after applying whatever was in the
> +            # kickstart file.
> +            if not self.anaconda.isKickstart:
> +                self.storage.doAutoPart = True
> +
>              allowdrives = []
>              model = self.drivelist.get_model()
>              for row in model:


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]