[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Run tune2fs on newly formatted ext[34] filesystems. (#495476)



On Thu, 2009-05-07 at 18:52 -0500, Eric Sandeen wrote:
> David Lehman wrote:
> > ---
> >  storage/formats/fs.py |   22 ++++++++++++++++++++++
> >  1 files changed, 22 insertions(+), 0 deletions(-)
> > 
> > diff --git a/storage/formats/fs.py b/storage/formats/fs.py
> > index c4cb1ca..23355b8 100644
> > --- a/storage/formats/fs.py
> > +++ b/storage/formats/fs.py
> > @@ -765,6 +765,28 @@ class Ext2FS(FS):
> >      _migratefs = "tune2fs"
> >      _defaultMigrateOptions = ["-j"]
> >  
> > +    def doMigrate(self, intf=None):
> > +        FS.doMigrate(self, intf=intf)
> > +        self.tuneFS()
> > +
> > +    def doFormat(self, *args, **kwargs):
> > +        FS.doFormat(self, *args, **kwargs)
> > +        self.tuneFS()
> > +
> > +    def tuneFS(self):
> > +        if not isys.ext2HasJournal(self.device):
> > +            # only do this if there's a journal
> > +            return
> > +
> > +        try:
> > +            rc = iutil.execWithRedirect("/usr/sbin/tune2fs",
> > +                                        ["-c0", "-i0", "-Odir_index",
> > +                                         "-ouser_xattr,acl", self.device],
> 
> dir_index is default already FWIW.

Pushed without the dir_index argument. Thanks.

> 
> -Eric  (wondering why on earth ext$FOO needs mount options to enable
> acls & user xattrs, but oh well)
> 
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list redhat com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]