[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Do not set a parent on the /mnt/sysimage/dev bind mount object (#499724).



On Fri, 2009-05-08 at 14:57 -0400, Chris Lumens wrote:
> Doing so means we eventually end up trying to bind mount /mnt/sysimage/dev
> onto /mnt/sysimage/dev, which of course is never going to work.  That means
> there's no device nodes and we can't get the boot blocks off devices to see
> if the upgrade bootloader option should even be offered.

Looks ok in spite of the tricky "not foo == bar".

> ---
>  storage/__init__.py |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/storage/__init__.py b/storage/__init__.py
> index d37fa40..90886db 100644
> --- a/storage/__init__.py
> +++ b/storage/__init__.py
> @@ -1574,7 +1574,7 @@ class FSSet(object):
>              if "noauto" in options.split(","):
>                  continue
>  
> -            if device.format.type == "bind":
> +            if device.format.type == "bind" and not device == self.dev:
>                  # set up the DirectoryDevice's parents now that they are
>                  # accessible
>                  #


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]