[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 1/2] Only set clearpart data if the command was provided in the kickstart file.



On Mon, 2009-05-11 at 11:59 -0400, Chris Lumens wrote:
> This prevents clearPartType from getting set to None, which causes problems
> in shouldClear.

The idea seems reasonable enough, but shouldn't the test be for None
since CLEARPART_TYPE_LINUX is 0?

Dave

> ---
>  kickstart.py |    9 +++++----
>  1 files changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/kickstart.py b/kickstart.py
> index eb79bd9..0bbfa25 100644
> --- a/kickstart.py
> +++ b/kickstart.py
> @@ -1182,10 +1182,11 @@ def fullCommandPass(anaconda, file, earlyKS):
>      anaconda.id.storage.ignoredDisks = earlyKS.ignoredisk.ignoredisk
>      anaconda.id.storage.exclusiveDisks = earlyKS.ignoredisk.onlyuse
>  
> -    anaconda.id.storage.clearPartType = earlyKS.clearpart.type
> -    anaconda.id.storage.clearPartDisks = earlyKS.clearpart.drives
> -    if earlyKS.clearpart.initAll:
> -        anaconda.id.storage.reinitializeDisks = earlyKS.clearpart.initAll
> +    if earlyKS.clearpart.type:
> +        anaconda.id.storage.clearPartType = earlyKS.clearpart.type
> +        anaconda.id.storage.clearPartDisks = earlyKS.clearpart.drives
> +        if earlyKS.clearpart.initAll:
> +            anaconda.id.storage.reinitializeDisks = earlyKS.clearpart.initAll
>  
>      storage.storageInitialize(anaconda)
>  


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]