[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Consider active-idle state of md device as accepatable status of device (#497407)



On Wed, 2009-05-13 at 15:44 +0200, Radek Vykydal wrote:
> This should fix traceback met when we were updating sysfs path attribute of md
> device in active-idle state (empty string was returned as the device was not in
> state clean or active). I think it is a state very rarely met in our tests.
> According to md.txt, it is "like active, but no writes have been seen for a
> while".  I prepared updates.img for testing, but we can't reproduce the bug.

Looks okay to me.

> ---
>  storage/devices.py |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/storage/devices.py b/storage/devices.py
> index 8213379..87d48f0 100644
> --- a/storage/devices.py
> +++ b/storage/devices.py
> @@ -2426,7 +2426,7 @@ class MDRaidArrayDevice(StorageDevice):
>          if os.access(state_file, os.R_OK):
>              state = open(state_file).read().strip()
>              log.debug("%s state is %s" % (self.name, state))
> -            if state in ("clean", "active"):
> +            if state in ("clean", "active", "active-idle"):
>                  status = True
>  
>          return status


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]