[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Don't schedule a format resize if reformat scheduled. (#500991)



Looks good.

On 05/15/2009 09:27 AM, David Lehman wrote:
---
  iw/lvm_dialog_gui.py       |    3 ++-
  iw/partition_dialog_gui.py |    2 +-
  2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/iw/lvm_dialog_gui.py b/iw/lvm_dialog_gui.py
index 5102588..733b776 100644
--- a/iw/lvm_dialog_gui.py
+++ b/iw/lvm_dialog_gui.py
@@ -1078,7 +1078,8 @@ class VolumeGroupEditor:
                      # check the lv's format also, explicitly, in case it is
                      # encrypted. in this case we must check them both.
                      if format.resizable and lv.format.resizable and \
-                       lv.targetSize != format.currentSize:
+                       lv.targetSize != format.currentSize and \
+                       usedev.format.exists:
                          new_size = lv.targetSize
                          actions.append(ActionResizeFormat(usedev, new_size))
                  elif lv.format.type:
diff --git a/iw/partition_dialog_gui.py b/iw/partition_dialog_gui.py
index 8a098a4..45748c2 100644
--- a/iw/partition_dialog_gui.py
+++ b/iw/partition_dialog_gui.py
@@ -291,7 +291,7 @@ class PartitionEditor:

                      try:
                          actions.append(ActionResizeDevice(request, size))
-                        if request.format.type:
+                        if request.format.type and request.format.exists:
                              actions.append(ActionResizeFormat(request, size))
                      except ValueError:
                          pass


--
David Cantrell <dcantrell redhat com>
Red Hat / Honolulu, HI


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]