[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 3/4] Return translated string from checkBootRequest.



To pick a few nits (generally the set looks fine)

On Thursday, May 21 2009, Chris Lumens said:
> @@ -212,15 +216,17 @@ class Alpha(Platform):
>      _diskType = parted.diskType["bsd"]
>  
>      def checkBootRequest(self, req):
> +        errors = Platform.checkBootRequest(self, req)
> +
>          disk = req.disk
>          if not disk:
> -            raise DeviceError("Boot partition has no disk")
> +            errors.append("Boot partition has no disk")

You missed marking this one with _()
  
> @@ -282,12 +288,16 @@ class IPSeriesPPC(PPC):
>          return ret
>  
>      def checkBootRequest(self, req):
> +        errors = PPC.checkBootRequest(self, req)
> +
>          bootPart = getattr(req, "partedPartition", None)
>          if not bootPart:
> -            raise DeviceError("Boot partition has no partedPartition")
> +            errors.append("Boot partition has no partedPartition")

And this one.  Which might be a bit hard for people to translate/understand
  
> @@ -338,15 +348,19 @@ class NewWorldPPC(PPC):
>          return ret
>  
>      def checkBootRequest(self, req):
> +        errors = PPC.checkBootRequest(self, req)
> +
>          disk = req.disk
>          if not disk:
> -            raise DeviceError("Boot partition has no disk")
> +            errors.append("Boot partition has no disk")

Lalala... this one too :)
  
Jeremy


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]