[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 3/4] Return translated string from checkBootRequest.



> > @@ -282,12 +288,16 @@ class IPSeriesPPC(PPC):
> >          return ret
> >  
> >      def checkBootRequest(self, req):
> > +        errors = PPC.checkBootRequest(self, req)
> > +
> >          bootPart = getattr(req, "partedPartition", None)
> >          if not bootPart:
> > -            raise DeviceError("Boot partition has no partedPartition")
> > +            errors.append("Boot partition has no partedPartition")
> 
> And this one.  Which might be a bit hard for people to translate/understand

I did this on purpose.  I figured they mean more to us than to users.
Of course if that's my reasoning, I should raise instead of append.
Which would everyone else prefer?

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]