[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 3/4] Return translated string from checkBootRequest.



On Thursday, May 21 2009, Chris Lumens said:
> > > @@ -282,12 +288,16 @@ class IPSeriesPPC(PPC):
> > >          return ret
> > >  
> > >      def checkBootRequest(self, req):
> > > +        errors = PPC.checkBootRequest(self, req)
> > > +
> > >          bootPart = getattr(req, "partedPartition", None)
> > >          if not bootPart:
> > > -            raise DeviceError("Boot partition has no partedPartition")
> > > +            errors.append("Boot partition has no partedPartition")
> > 
> > And this one.  Which might be a bit hard for people to translate/understand
> 
> I did this on purpose.  I figured they mean more to us than to users.
> Of course if that's my reasoning, I should raise instead of append.
> Which would everyone else prefer?

I was wondering if that was the case.  In my mind, the difference boils
down to
* raise an exception (untranslated) if the only way it should occur is
  due to a bug in the code
* return a nicely formatted, translated error to the user if it can
  occur because they picked something stupid in the UI 

Jeremy


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]