[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 1/9] Allocate fixed-size requests before growable requests.



> diff --git a/storage/partitioning.py b/storage/partitioning.py
> index 1e2ee40..09bf27e 100644
> --- a/storage/partitioning.py
> +++ b/storage/partitioning.py
> @@ -397,11 +397,11 @@ def partitionCompare(part1, part2):
>      # primary-only to the front of the list
>      ret -= cmp(part1.req_primary, part2.req_primary) * 200
>  
> -    # larger requests go to the front of the list
> -    ret -= cmp(part1.req_base_size, part2.req_base_size) * 100
> -
>      # fixed size requests to the front
> -    ret += cmp(part1.req_grow, part2.req_grow) * 50
> +    ret += cmp(part1.req_grow, part2.req_grow) * 100
> +
> +    # larger requests go to the front of the list
> +    ret -= cmp(part1.req_base_size, part2.req_base_size) * 50
>  
>      # potentially larger growable requests go to the front
>      if part1.req_grow and part2.req_grow:

ACK on this part.  I think this is how we used to do it in old world
storage land, even.

> @@ -412,6 +412,11 @@ def partitionCompare(part1, part2):
>          else:
>              ret -= cmp(part1.req_max_size, part2.req_max_size) * 25
>  
> +    # give a little bump based on mountpoint
> +    if hasattr(part1.format, "mountpoint") and \
> +       hasattr(part2.format, "mountpoint"):
> +        ret -= cmp(part1.format.mountpoint, part2.format.mountpoint) * 10
> +
>      if ret > 0:
>          ret = 1
>      elif ret < 0:

What problem are you running into that this solves?

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]