[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH parted] Handle swap flag in msdos type labels



Hans de Goede wrote:
> From: David Cantrell <dcantrell redhat com>
>
> Original patch by David Cantrell <dcantrell redhat com>, I
> (Hans de Goede <hdegoede redhat com>) made the following changes:
> -msdos_partition_is_flag_available() should return 1 for swap flag
> -Only change the partition type to 82 when setting the swap flag
>  on dos labels, not when resetting it

Hans,

What is the motivation for this change?

The existing "set 1 swap on" functionality is documented to be
specific to MAC partition tables:

    `swap'
          (Mac) - this flag should be enabled if the partition is the
          swap device to be used by Linux.


AFAICS, it's not intended to be a general (partition-table-independent)
way to set the per- partition "type".  For an msdos partition table,
if you just want to set the type of a newly-created partition to swap(82),
use mkpart's file system type argument:

    parted -s $dev mkpart primary linux-swap 60s 100s


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]