[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Fix liveinst to (1) not unmount /dev/pts, (2) unmount in order (509632).



Looks like correct terrible liveinst code to me.  Ack.

On 10/13/2009 05:17 PM, Chris Lumens wrote:
> ---
>  liveinst/liveinst |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
> 
> diff --git a/liveinst/liveinst b/liveinst/liveinst
> index eed4e41..a37d923 100755
> --- a/liveinst/liveinst
> +++ b/liveinst/liveinst
> @@ -58,7 +58,12 @@ fi
>  
>  # devkit-disks is now mounting lots of stuff.  for now, let's just try to unmount it all
>  umount /media/*
> -for mnt in $(cat /proc/mounts |grep ^/dev |grep -v live | awk {'print $2;'}) ; do umount $mnt 2>/dev/null ; done
> +tac /proc/mounts | grep ^/dev | grep -v live | while read dev mntpoint rest; do
> +    if [ -b $dev ]; then
> +       umount $mntpoint 2>/dev/null
> +    fi
> +done
> +
>  /sbin/swapoff -a
>  /sbin/lvm vgchange -an --ignorelockingfailure
>  


-- 
        Peter

I number the Linux folks among my personal heroes.
		-- Donald Knuth


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]