[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 2/2] Find and format any unformatted DASD devices (#528386).



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tue, 27 Oct 2009, Steffen Maier wrote:

On 10/27/2009 08:46 PM, David Cantrell wrote:
On Tue, 27 Oct 2009, Steffen Maier wrote:
On 10/27/2009 03:07 AM, David Cantrell wrote:
+
+            rc = intf.messageWindow(title, msg,
+                                    custom_icon="error", type="yesno")
+            if rc == 0:
+                sys.exit(0)

I would like to see an else case here when there is no UI. As Hans
already pointed out, silently low-level formatting DASDs which do not
have any known format, is a bit hard. Suppose such DASD has an unknown
format with important data on it. Then we should not silently format it
and loose the data. A kickstart command as suggested by Hans sounds good.
How was this case handled with RHEL5?

I agree with Chris here, we can just make use of 'clearpart --initlabel'
rather than introducing a new kickstart command.

Would this kill all potential partitions on DASDs that were already both
low-level formatted as well as already having partitions?
That would mean whenever the user had one or more DASDs yet to be
low-level formatted, he would have to recreate all existing partitioning
on other DASDs which had been in use and thus prepared before.
How was this handled with RHEL5 in order not to introduce regressions?

Hmm, yeah that could be a problem.  I'm going to save the kickstart handling
for another patch.  I want to talk to clumens and see what, if anything,
exists in kickstart that we could define/use for unformatted DASDs.

- -- David Cantrell <dcantrell redhat com>
Red Hat / Honolulu, HI

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkrnh9UACgkQ5hsjjIy1Vkk9TQCggA+JPFehGxzkYI3fRuoQx0BF
EkEAoLBZDphsKhqgEkaqLumIl+f0n/bi
=NcAw
-----END PGP SIGNATURE-----


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]