[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 4/4] Disable ipv6 kernel modules if user disables IPv6 (#537887)



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/09/2010 10:57 AM, Brian C. Lane wrote:
> On 08/06/2010 10:45 PM, dcantrell redhat com wrote:
>> From: David Cantrell <dcantrell redhat com>

>> +            f = open(c, "w+")
>> +            if header:
>> +                f.write(header)
> 
> header and check for isfile isn't needed, since this is the first time
> it has been written, and you're using "w+" which will overwrite it anyway.
> 

and I just realized there is no "w+" mode, r+ is read/write. It seems to
work, but should probably be changed to plain old "w"

- -- 
Brian C. Lane <bcl redhat com>
Red Hat / Port Orchard, WA
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: Remember Lexington Green!

iQEVAwUBTGBC2BF+jBaO/jp/AQJ7PQf+J7jiWX6+xUFNFBNkQAmfrPSpvvll68P0
ZA89vRQ3Z9xu5nnPL90kM3lQ2sp/Fi+bY5qn08dceLRO553oUkKEU7LGVDEXdZm7
O8LxLpzkG+IQH/CyW5iQrc2HSsith/p8k3fK5xQdZaIIzmaTvNDAVNw+HQgUV738
6IamxVsvlZ63TgpX6pYcyrV57OhqEoEBZuv0N/DXnBOGNkQ2QeRRBTkuFRqFWkZf
/J4vLfbOL65VZbveoQj7B8R6uq6LhZoTwcPozVxoo2bYOkyQnCtVvEaj1yVQNpkN
qnV6pRTSvN1L0LeejaAsoaTlnMb8sTxjoXortZPRpps4b0aXfpQ2ag==
=ewqR
-----END PGP SIGNATURE-----


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]