[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 2/3] Display a warning message on TAINT_HARDWARE_UNSUPPORTED (#623140).



On Wed, 2010-12-01 at 16:35 +0100, Martin Gracik wrote:

> Wouldn't it be better to convert the contents to int and compare to 0?
> and I guess there's no need to ignore case when comparing something to
> "0".

It is a good idea to convert to an int and then check against the actual
taint bit. This is a set of bits, not just tainted hardware. A quick
reading suggests that right now you'll treat all tainting equally. This
might actually be desired in RHEL but just FYI not all values in that
file are created equal.

(my suggestion is to go back to whatever BZ originally requested this,
please ensure I'm on the CC, then ask what to actually test against).

Jon.




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]