[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] On live installs, the syslog is /var/log/dmesg. (#568814).



On Fri, 2010-02-26 at 16:01 -0500, Chris Lumens wrote:
> This is because we use the system syslog on live installs instead of
> starting our own with its own special file locations.
> ---
>  exception.py |   16 ++++++++++------
>  1 files changed, 10 insertions(+), 6 deletions(-)
> 
> diff --git a/exception.py b/exception.py
> index 7e27945..1075717 100644
> --- a/exception.py
> +++ b/exception.py
> @@ -90,6 +90,15 @@ class AnacondaExceptionHandler(ExceptionHandler):
>          os.kill(os.getpid(), signal.SIGKILL)
>  
>  def initExceptionHandling(anaconda):
> +    fileList = [ "/tmp/anaconda.log", "/tmp/lvmout", "/tmp/resize.out",
> +                 "/tmp/program.log", "/tmp/storage.log", "/tmp/yum.log",
> +                 anaconda.rootPath + "/root/install.log",
> +                 anaconda.rootPath + "/root/upgrade.log", "/proc/cmdline" ]
> +    if flags.livecdInstall:
> +        fileList.extend(["/var/log/dmesg"])
> +    else:
> +        fileList.extend(["/tmp/syslog"])
> +

Why not just add /var/log/dmesg to the list? I'm okay with either, but
just sticking it in the list seems simpler.

Dave

>      conf = Config(programName="anaconda",
>                    programVersion=isys.getAnacondaVersion(),
>                    attrSkipList=[ "backend.ayum",
> @@ -116,12 +125,7 @@ def initExceptionHandling(anaconda):
>                                   "intf.icw.stockButtons",
>                                 ],
>                    localSkipList=[ "passphrase", "password" ],
> -                  fileList=[ "/tmp/syslog", "/tmp/anaconda.log", "/tmp/lvmout",
> -                             "/tmp/resize.out", "/tmp/program.log",
> -                             "/tmp/storage.log", "/tmp/yum.log",
> -                             anaconda.rootPath + "/root/install.log",
> -                             anaconda.rootPath + "/root/upgrade.log",
> -                             "/proc/cmdline"])
> +                  fileList=fileList)
>      handler = AnacondaExceptionHandler(conf, anaconda.intf, ReverseExceptionDump)
>      handler.install(anaconda)
>  



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]