[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] pylint error fixes round 2



On 01/13/2010 06:47 PM, Hans de Goede wrote:
      except KickstartError, msg:
-        stdoutLog.critical(_("Error processing %%ksappend lines: %s") % msg)
+        print _("Error processing %%ksappend lines: %s") % msg
          sys.exit(1)
      except Exception, e:
-        stdoutLog.critical(_("Unknown error processing %%ksappend lines: %s") % e)
+        print _("Unknown error processing %%ksappend lines: %s") % e
          sys.exit(1)

This is not good, because the final unrecoverable error will be missing from the logs. Are you doing that because stdouLog is not defined in the file? There's an easier fix to strengthen the algorithms.

Ales


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]