[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 2/6] Make sure MultipathDevice is setup correctly.



On 01/20/2010 07:24 PM, David Lehman wrote:
> On Wed, 2010-01-20 at 19:03 -0500, Peter Jones wrote:
>> Make sure exists is set when creating MultipathDevice, as well as any
>> other ancillary data.  Also revamp MultipathDevice.status since we now
>> can create it in realtime like everything else does.
>> ---
>>  storage/devices.py |   25 +++++++++++++++----------
>>  1 files changed, 15 insertions(+), 10 deletions(-)
>>
>> diff --git a/storage/devices.py b/storage/devices.py
>> index 4137d4f..ab4739a 100644
>> --- a/storage/devices.py
>> +++ b/storage/devices.py
>> @@ -2967,21 +2968,25 @@ class MultipathDevice(DMDevice):
>>          
>>              May be overridden by a sub-class for e.g. RDAC handling.
>>          """
>> -        if not hasattr(self, "_serial"):
>> +        if not hasattr(self, "_identity"):
>>              raise RuntimeError, "setupIdentityFromInfo() has not been called."
>> -        return self._serial
>> +        return self._identity
>>  
>>      @property
>>      def status(self):
>> -        return self._isUp
>> +        """ The device's status (True means active). """
>> +        if not os.path.exists(self.path):
>> +            return False
>> +
>> +        return True
> 
> Why not just inherit DMDevice.status?

Yeah, you're right, that's better.  Done in my local tree.

-- 
        Peter

What we need is either less corruption, or more chances to
participate in it.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]