[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [pykickstart 1/2] repo: new parameter '--trustedssl'.



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/02/2010 05:57 AM, Ales Kozumplik wrote:
> +
> +class RHEL6_Repo(F13_Repo):
> +    removedKeywords = F13_Repo.removedKeywords
> +    removedAttrs = F13_Repo.removedAttrs
> +
> +    def _getParser(self):
> +        op = F13_Repo._getParser(self)
> +        op.add_option("--trustedssl", action="store_true", default=False)
> +        return op
> +

Shouldn't this be:

op.add_option("--trustedssl", action="store", type="ksboolean")

instead? That matches the F11 --ignoregroups option and would be
consistent. That also means that it needs to be passed an =true instead
of being bare.

I do notice that the wiki documentation for --ignoregroups isn't
complete, so I'll fix that now.

- -- 
Brian C. Lane <bcl redhat com>
Red Hat / Port Orchard, WA
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQEVAwUBTC5lbBF+jBaO/jp/AQJD6QgAn30HNrB41gHk/zjoNs8GH4Zj/n1pc99l
COOTSp8FSiO15n91gacqPt9c92nHsFzSMeVL5Cf4bWT6BVRsBBSSs872dKSZ2Ier
NhHCbHPUrH6LjpB7LQilQscGdNAGypi74LKoOH6EMnPDbJnWjcENBLdEQcfaA9/B
/KDo1fP/H+IWgIJDwCEUujWn7eeHLTXQT9je1sxD8ibtMAVDtxRh99A0+YR8mBUm
y6Y+rakeSF1f/Xn+htHWAbtfwEkKY7NILwfT/8P2EKZ3/dnal8GW9ts/6XHQKqnS
7QAXq1CKgCT6jPHmtpgzsCsjtZGQzqP8ExUbHs1j3txZKN/KQF9qIA==
=UZI4
-----END PGP SIGNATURE-----


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]