[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [pykickstart 2/2] method: new parameter '--trustedssl' after --url.



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/02/2010 05:57 AM, Ales Kozumplik wrote:
> ---
>  pykickstart/commands/method.py  |   26 ++++++++++++++++++++++++++
>  pykickstart/handlers/control.py |   16 ++++++++--------
>  tests/commands/method.py        |   12 ++++++++++++
>  3 files changed, 46 insertions(+), 8 deletions(-)
> 
> diff --git a/pykickstart/commands/method.py b/pykickstart/commands/method.py
> index d37f19f..5151bb2 100644
> --- a/pykickstart/commands/method.py
> +++ b/pykickstart/commands/method.py
> @@ -156,3 +156,29 @@ class F13_Method(FC6_Method):
>              op.add_option("--proxy")
>  
>          return op
> +
> +class RHEL6_Method(F13_Method):
> +    removedKeywords = F13_Method.removedKeywords
> +    removedAttrs = F13_Method.removedAttrs    
> +
> +    def __init__(self, *args, **kwargs):
> +        F13_Method.__init__(self, *args, **kwargs)
> +
> +        self.trustedssl = False
> +
> +    def __str__(self):
> +        retval = F13_Method.__str__(self)
> +
> +        if self.method == "url" and self.trustedssl:
> +            retval = retval.strip()
> +            retval += " --trustedssl"
> +

Looking at previous examples, I think this needs a \n at the end.


> +        return retval
> +
> +    def _getParser(self):
> +        op = F13_Method._getParser(self)
> +
> +        if self.currentCmd == "url":
> +            op.add_option("--trustedssl", action="store_true", default=False)

Same comment as with the other patch. Use ksboolean here?

Other than those questions, it looks good to me and I think will be a
nice addition.

- -- 
Brian C. Lane <bcl redhat com>
Red Hat / Port Orchard, WA
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQEVAwUBTC5opRF+jBaO/jp/AQJt3gf+NZjQANeOM8UrzaBFfHk2V5khKEVNMjGg
GrLPxr8ky7WquLH0zCc8oMrdDa0SNz2pgA4S0etNCXaNgOyZCumCESqBK/g1mzLq
qRJhM1rcqTHjSDxkN5tRgjkzmMFd89V9xA/jgFUbsINGfzSoXTXCAqH+Q1LAllrd
Hy0ONu1YLaPN477NPLOAVSBx+ZtZPyxiBi98WpNvv+BxvHJzZTpZN05EUXEHfG30
3TuWrZ6HCspWz9x2g60a/HeoP1DM2MwvAjsWM91MUdRrMN08jWZYfrPRUq0PBydF
F4WotapvglgJNUUp4pw42Z8+GKaG6dULOOkCTzrvnmXfmHjeZqstbA==
=Ac+y
-----END PGP SIGNATURE-----


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]