[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [pykickstart 1/2] repo: new parameter '--trustedssl'.



Hi,

On 07/03/2010 12:17 AM, Brian C. Lane wrote:
Shouldn't this be:

op.add_option("--trustedssl", action="store", type="ksboolean")

instead? That matches the F11 --ignoregroups option and would be
consistent. That also means that it needs to be passed an =true instead
of being bare.

But we use store_true a lot in pykickstart. And I think it's good one doesn't have to ues =true etc. with it, i.e. the connection is not trusted by default. See '--noipv4' in network.py for instance.


I do notice that the wiki documentation for --ignoregroups isn't
complete, so I'll fix that now.

That reminds me I shouldn't forget to update the wiki once this is pushed.

Ales


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]