[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [pykickstart 1/2] repo: new parameter '--trustedssl'.



> diff --git a/tests/commands/repo.py b/tests/commands/repo.py
> index 06a3a9b..27c3140 100644
> --- a/tests/commands/repo.py
> +++ b/tests/commands/repo.py
> @@ -98,5 +98,14 @@ class F13_TestCase(F11_TestCase):
>          self.assert_parse_error("repo --name=blah --baseurl=www.domain.com --proxy",
>                                  KickstartParseError)
>  
> +class RHEL6_TestCase(F13_TestCase):
> +    def runTest(self):
> +        F13_TestCase.runTest(self)        
> +        #pass
> +        self.assert_parse("repo --name=blah --baseurl=https://www.domain.com --trustedssl")
> +        #fail
> +        self.assert_parse_error("repo --name=blah --baseurl=https://www.domain.com --trustedssl=yeeeaah", KickstartParseError)
> +        
> +
>  if __name__ == "__main__":
>      unittest.main()

Thanks for adding test cases.  I'd also like you to add a test case to
verify that if you pass --trustedssl as a parameter, you also get it on
the output side as well.  You can do that by passing a second argument
to assert_parse.  See tests/commands/authconfig.py for an example.

I assume you also ran "make test" and "make check" to verify everything
works?

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]