[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [master 1/2] logging: support logging through virtio-serial (#576439).



> >Why didn't you use mlLoadModuleSet directly? This duplicates code a bit..
> >
> 
> Good question! I thought about and then found out it called
> _doLoadModule which is calling logging functions. But at that point
> logging is yet to be set up.

Perhaps you can conditionalize logging in _doLoadModule to not be called
if it's not set up, then?  I think that would be much preferred to
duplicating module loading code.

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]