[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 3/3] Improve parsing and pass the devel flag to loader through the command line



On 07/14/2010 07:02 PM, Brian C. Lane wrote:
> On 07/14/2010 07:36 AM, Martin Sivak wrote:
>> This gets rid of ugly checking for this in /proc/cmdline in loader and init checks if devel is actually a single word to avoid conflicts
>> ---
>>  loader/init.c   |   36 +++++++++++++++++++++++++++++++++---
>>  loader/loader.c |   28 +++++++++++++---------------
>>  2 files changed, 46 insertions(+), 18 deletions(-)

> I think you could simplify this by using strstr(develstart, " devel"),
> that would eliminate the need to strip spaces and do a strncmp on every
> word of the command line.
> 
> devel is always going to have a space in front of it, so you only have
> to confirm that it is a single word.

What if I put "devel" as first option into my boot options?

Steffen

Linux on System z Development

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]