[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Skip the Filter UI in Basic Storage mode (#598420)



On 07/22/2010 05:02 PM, Hans de Goede wrote:
> ---
>  pyanaconda/iw/filter_gui.py  |   32 ++++++++------------------------
>  pyanaconda/iw/filter_type.py |    7 ++++---
>  2 files changed, 12 insertions(+), 27 deletions(-)
> 

> diff --git a/pyanaconda/iw/filter_type.py b/pyanaconda/iw/filter_type.py
> index 940de7e..2b4e5d9 100644
> --- a/pyanaconda/iw/filter_type.py
> +++ b/pyanaconda/iw/filter_type.py
> @@ -65,9 +65,10 @@ class FilterTypeWindow(InstallWindow):
>                                            "probably it."))
>          self.buttonGroup.addEntry("complex", _("Specialized Storage Devices"),
>                                    descr=_("Installs or upgrades to devices such as "
> -                                          "Storage Area Networks (SANs) or mainframe "
> -                                          "attached disks (DASD), usually in an "
> -                                          "enterprise environment"))
> +                                          "Storage Area Networks (SANs). This option "

Now, I'm missing DASDs which are not necessarily understood under the
term of SAN since they do not use FCP.
Also the term "enterprise environment" seemed useful to me.

> +                                          "will allow you to add FCoE / iSCSI / zFCP "
> +                                          "disks and to filter out LUNs the "

Isn't the dialog about filtering disks, i.e. not just LUNs? After all,
it can filter DASDs which are usually not referred to as LUNs.
Therefore, I would like to suggest to make the wording more general:
"disks and to filter out disks the "

> +                                          "installer should ignore."))
> 
>          widget = self.buttonGroup.render()
>          vbox.pack_start(widget, expand=True, fill=True)

Steffen

Linux on System z Development

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]