[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 1/6] Add readvars.c for parsing command line args and shell vars.



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/22/2010 02:15 PM, David Cantrell wrote:
> Add functions to help simplify parsing of command line arguments as well
> as files containing shell-style variables.  These functions will parse
> strings where values either stand alone or are of the key=value format.
> The idea is to reduce the code surrounding /proc/cmdline handling as
> well as add in support for easy parsing of files containing shell
> variables (e.g., ifcfg files).

I think the GError's need to be dealt with when returned. At the least
free'd up to prevent memory leaks.

Looks good other than that.

- -- 
Brian C. Lane <bcl redhat com>
Red Hat / Port Orchard, WA
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQEVAwUBTEjZDBF+jBaO/jp/AQLoKgf+Mpm8s0Af4uhowwIJDzaftKoRXKLuWPvA
QzJbVAxp/tAF84ZjIpmB7ql4oc+kpRd7yYb4UVirGOEhKfni1VlKl9PA9qjgWyq3
pafbWlak+PeE/2NaIXe+gx6ERSaKr9s+hqeG4EsS9YPGFvdtnrhOmDM3aAjCoG19
3qOWqxIk6okr2AyIJvyfjEFwmVzUDSbr4tdAPPVwTzp0hXHOabA3sPstyJ5gPBkn
lizgM/ggldjRe7SAQsA4M+vpf4TsF0qs/dyDfTV2mZvJ3m/x+dGbExkWkK1z9Pg6
gEwwzIkU0SvHmiveTKyQXu4ZhYBY8gqRzYclJ1RTQYvO+tow9cgd4A==
=II9b
-----END PGP SIGNATURE-----


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]