[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 5/6] Use readvars_parse_*() in loader/loader.c



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/22/2010 02:15 PM, David Cantrell wrote:

Looks good, much less fragile I think.

> -                if (!strncasecmp(argv[i], "vesa", 4)) {
> +                if (!strcasecmp(k, "vesa")) {
>                      checked_asprintf(&extraArgs[numExtraArgs],
>                                       "--xdriver=vesa");
>  
>                      logMessage(WARNING, "\"vesa\" command line argument is deprecated.  use \"xdriver=vesa\".");

Why not just kill it? How long as it been deprecated for?

- -- 
Brian C. Lane <bcl redhat com>
Red Hat / Port Orchard, WA
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQEVAwUBTEjiaRF+jBaO/jp/AQI3bgf/dmbneoYEl5NajW+I+LiJ2hNY2aFhXWXI
qC9iE5TmoM3Q/0PvGfXr0WeAfZ6DQ6tVlq2CyVyLfMIt5oj5pTWHReiP71PVoADy
bIAw9bOdxTqBCEyotQaV2FNoP1JwGOcigapv+GDhgLCPhgT4h690ryH/eG3F0dJ9
NftC/Y/TSGE4tcEk0g6TUllMycWN5eXqAcswk83loRdIeWD8+FXTHCm3qJ3+u3it
SqECb05fjTUZH+XLQYPqhm+rUk3M955A8c6l+i8nhMBowYICkshSwpeQYt6gF5Tn
ms9UkrQ/ViUz6gLyNbUqe5vE4rOHzkL+POiNHrF2HAID5FY3s9cT5w==
=E8CR
-----END PGP SIGNATURE-----


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]