[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 6/6] Use readvars_parse_file in loader/init.c



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/22/2010 02:15 PM, David Cantrell wrote:

> +static gchar *getSyslog(gchar **virtiolog) {
> +    gpointer value = NULL;
> +    gchar *addr = NULL;
> +

Check virtiolog to make sure it is pointing someplace before using it.


> +    if (!g_hash_table_lookup_extended(cmdline, "syslog", NULL, value)) {

Pass &value

> +    if (!g_hash_table_lookup_extended(cmdline, "syslog", NULL, value)) {

Pass &value

> +    if (g_hash_table_lookup_extended(cmdline, "devel", NULL, value)) {
> +        printf("Enabling development mode - cores will be dumped\n");
> +        isDevelMode = TRUE;

That is sooo much nicer :)

- -- 
Brian C. Lane <bcl redhat com>
Red Hat / Port Orchard, WA
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQEVAwUBTEjlKxF+jBaO/jp/AQJjhQgAnfIbEHiaVvB3TCJNFfZzfva3IhKP5O2u
rYTQxezRJbRUeW0jtPc9AUP4PAjmMM1f/nGhggwZd+s406vTGKuBRoueQ6Ig89j6
VRtg/QCM2mJ4SkYTAq52xJ390nzTN5bi2o0YKDHNs0DxbI8WZDLVQu/VoqbtTSCo
fWpWQJE1NLBLDIpEcI/5GOX1kgGOlh7kOzGMsoQP8jE2foQzRifjI3gl+pJBvb9D
xqcoc7v990R3t58ITa+/r/QTKfVJIfSvBCG5Spi9msPC9tUQMfTm7l9+8QbshJEt
2WbZbq21KolDUgoB4iu04wvGweRNt39qIh0RtQ02htta09z/krut/A==
=YqPa
-----END PGP SIGNATURE-----


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]