[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 5/6] Use readvars_parse_*() in loader/loader.c



On Thu, 22 Jul 2010, Brian C. Lane wrote:

On 07/22/2010 02:15 PM, David Cantrell wrote:

Looks good, much less fragile I think.

-                if (!strncasecmp(argv[i], "vesa", 4)) {
+                if (!strcasecmp(k, "vesa")) {
                     checked_asprintf(&extraArgs[numExtraArgs],
                                      "--xdriver=vesa");

                     logMessage(WARNING, "\"vesa\" command line argument is deprecated.  use \"xdriver=vesa\".");

Why not just kill it? How long as it been deprecated for?

Gone.  Added a patch to remove this in the next patch series.

--
David Cantrell <dcantrell redhat com>
Red Hat / Honolulu, HI


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]