[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 6/6] Use readvars_parse_file in loader/init.c



On Thu, 22 Jul 2010, Brian C. Lane wrote:

On 07/22/2010 02:15 PM, David Cantrell wrote:

+static gchar *getSyslog(gchar **virtiolog) {
+    gpointer value = NULL;
+    gchar *addr = NULL;
+

Check virtiolog to make sure it is pointing someplace before using it.

The 2nd g_hash_table_lookup_extended() in this function is meant to do that.
Updated in the next patch series.  I was not supposed to look up syslog twice,
but look up syslog first then virtiolog.

+    if (!g_hash_table_lookup_extended(cmdline, "syslog", NULL, value)) {

Pass &value

+    if (!g_hash_table_lookup_extended(cmdline, "syslog", NULL, value)) {

Pass &value

Fixed, thanks.

--
David Cantrell <dcantrell redhat com>
Red Hat / Honolulu, HI


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]