[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 2/3] Make sure multipathd starts on systems using mpath storage (#615040)



> That is unfortunate.  How about this:
> 
> 
> [PATCH 2/3] Make sure multipathd starts on systems using mpath storage (#615040)
> 
> Multipath storage is currently the only type of storage where we need to
> make sure a userspace service is running.  Add in support for us to
> expand on this later if necessary.

You're going in the right direction.  However, you won't have a ksdata
object unless you're doing a kickstart install either.  I should have
explained that in the previous mail too, I suppose.

Perhaps what you should do is have a storage.services property that does
the map and set stuff, then have instdata refer to that as well...

> diff --git a/instdata.py b/instdata.py
> index aefad18..0b60656 100644
> --- a/instdata.py
> +++ b/instdata.py
> @@ -169,6 +169,12 @@ class InstallData:
>                                     self.rootPassword["lock"],
>                                     algo=self.getPassAlgo())
> 
> +        for svc in self.ksdata.services.enabled:
> +            iutil.execWithRedirect("/sbin/chkconfig",
> +                                   [svc, "on"],
> +                                   stdout="/dev/tty5", stderr="/dev/tty5",
> +                                   root=self.anaconda.rootPath)
> +
>          if self.anaconda.isKickstart:
>              for svc in self.ksdata.services.disabled:
>                  iutil.execWithRedirect("/sbin/chkconfig",

services = self.anaconda.storage.services
if self.anaconda.isKickstart:
    services.extend(self.ksdata.services.enabled)

for svc in services:
    ...

Note that for master, in addition to removing "id", you'll want to use
"if self.ksdata" instead because isKickstart does not exist.

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]