[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] In the filter UI, also ignore devices that do not report a size (#594803).



On 06/10/2010 08:30 PM, Chris Lumens wrote:
+    if not os.path.isfile(attribute):

Do we care about symlinks?

Yes, likely.  Added "or not os.path.islink(attribute)".


Should be 'and not ...', no? otherwise it succeeds for regular files too (and the filter is then empty and nothing can be installed).

Ales


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]