[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Branch 'rhel6-branch' - isys/isys.py network.py vnc.py



On 06/30/2010 07:42 PM, Brian C. Lane wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06/29/2010 01:05 PM, Chris Lumens wrote:
@@ -509,8 +510,11 @@ def isWireless(dev):
      else:
          return False

-# Get the IP address for a network device.
-def getIPAddress(dev):
+# Get IP addresses for a network device.
+# Returns list of ipv4 and ipv6 addresses.
+# With version=4 returns only ipv4 addresses,
+# with version=6 returns only ipv6 addresses.
+def getIPAddresses(dev, version=None):
      if dev == '' or dev is None:
         return None

Could we put comments like these into docstrings instead of comments?
Just in case I want to run doxygen on the code :)


Yes, I had been thinking about doing so in my patches,
but here my inner calling to be consistent (apparently in
wrong aspect here) with existing code won again. Next time:)

Radek


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]