[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 21/22] TODO? don't just let last device in the loop win in Network.write()



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Nack.  This comment does not need to be a patch.  File it at as a BZ or add it
to a git commit message.

On Tue, 27 Apr 2010, Radek Vykydal wrote:

See comments in the patch.
---
network.py |    6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/network.py b/network.py
index 1c8bf67..609680e 100644
--- a/network.py
+++ b/network.py
@@ -618,6 +618,12 @@ class Network:
                except:
                    log.warning("unable to copy %s to target system" % (dhclientconf,))

+
+        # TODORV: note that we use the last dev from the loop above
+        # at some places below which is ok for one net device, but
+        # maybe not if we have more devices - perhaps we should take
+        # care of this case.
+
        # /etc/sysconfig/network
        if (not instPath) or (not os.path.isfile(destnetwork)) or flags.livecdInstall:
            newnetwork = "%s.new" % (destnetwork,)


- -- David Cantrell <dcantrell redhat com>
Red Hat / Honolulu, HI

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkvfkeoACgkQ5hsjjIy1VkmTVQCeL3APNair+UOGZsrDFtMpAqpG
tDMAoOo/V90PZikeQ9vqxHp6uWZSUxAv
=JHin
-----END PGP SIGNATURE-----


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]