[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 2/2] Clean up wording for oversized LVs (#587459)



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Mon, 3 May 2010, Hans de Goede wrote:

The new message suggests / could be read as the VG still having
tempvg.size free, but AFAIK tempvg.size is the VG size,
not the free space in the VG.

Good point.  I reworded it a bit and sent the updated patch as part of the
four patch series I posted today.  However, I'm not really sure the rewording
clears up the confusion for users any less.

On 05/02/2010 01:29 AM, David Cantrell wrote:
---
  iw/lvm_dialog_gui.py |   15 ++++++++-------
  1 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/iw/lvm_dialog_gui.py b/iw/lvm_dialog_gui.py
index ec043de..cffb68c 100644
--- a/iw/lvm_dialog_gui.py
+++ b/iw/lvm_dialog_gui.py
@@ -707,13 +707,14 @@ class VolumeGroupEditor:
                      templv.size = size
                  except ValueError:
                      self.intf.messageWindow(_("Not enough space"),
- _("The logical volumes you have " - "configured require %(size)d MB," - " but the volume group only has " - "%(tempvgsize)d MB. Please " - "either make the volume group " - "larger or make the logical "
-                                              "volume(s) smaller.")
+                                            _("The size entered for this "
+ "logical volume (%(size)d MB) " + "exceeds the available space "
+                                              "of the volume group "
+ "(%(tempvgsize)d MB). Please " + "make the volume group larger " + "or make the logical volume "
+                                              "smaller.")
                                                % {'size': size,
'tempvgsize': tempvg.size},
                                              custom_icon="error")


- -- David Cantrell <dcantrell redhat com>
Red Hat / Honolulu, HI

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkvfsaEACgkQ5hsjjIy1Vkno+ACg7TuW2s0nz1+JuHN4KeNIdi+N
YFUAn2hUlqcifOfrDp8djQDRrB0BYhXl
=1BMn
-----END PGP SIGNATURE-----


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]