[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 1/4] Clean up wording for oversized LVs (#587459)



Hi,

Better, but not really pretty. It would be better IMHO to just figure
out with some calculation how much free space is still available and
show that in the error dialog (don't we already calculate this somewhere?).

Anyways, I would prefer a better dialog, but if that turns out to be
hard to do, ACK.

Regards,

Hans


On 05/04/2010 06:46 AM, David Cantrell wrote:
---
  iw/lvm_dialog_gui.py |   16 +++++++++-------
  1 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/iw/lvm_dialog_gui.py b/iw/lvm_dialog_gui.py
index ec043de..7d1a262 100644
--- a/iw/lvm_dialog_gui.py
+++ b/iw/lvm_dialog_gui.py
@@ -707,13 +707,15 @@ class VolumeGroupEditor:
                      templv.size = size
                  except ValueError:
                      self.intf.messageWindow(_("Not enough space"),
-                                            _("The logical volumes you have "
-                                              "configured require %(size)d MB,"
-                                              " but the volume group only has "
-                                              "%(tempvgsize)d MB.  Please "
-                                              "either make the volume group "
-                                              "larger or make the logical "
-                                              "volume(s) smaller.")
+                                            _("The size entered for this "
+                                              "logical volume (%(size)d MB) "
+                                              "combined with the size of the "
+                                              "other logical volume(s) "
+                                              "exceeds the size of the "
+                                              "volume group (%(tempvgsize)d "
+                                              "MB). Please make the volume "
+                                              "group larger or make the "
+                                              "logical volume smaller.")
                                                % {'size': size,
                                                   'tempvgsize': tempvg.size},
                                              custom_icon="error")


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]